-
Notifications
You must be signed in to change notification settings - Fork 934
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: concat of mixed and subtype #444
Conversation
By the way, fixes #399 (in issue's example a problem in concating mixed and date, not in when). |
Additional commit (can be separated into separate PR, but then i will have to make rebase after this PR will be merged). Small one, but fixes #381. Smallest repo of a problem: yup.object({
conditional: yup.object().when("$check", {
is: true,
then: yup.object({
lazy: yup.lazy(val => yup.number()),
})
}),
}).validateSync({}, {context: {check: true}}); It fixes it, but underlying cause of the issue still there:
Current solution solves the last point: skip merging same schema's or values. Breaking addition will be a removal of original |
e250193
to
2978df1
Compare
2978df1
to
0f2889e
Compare
0f2889e
to
461face
Compare
thanks! |
Separate PR from #443.